Skip to content

[IMP][10.0][document_page_approval] Change Requests and workflow improvements on documents (#155)#160

Merged
max3903 merged 1 commit into
OCA:10.0from
ivantodorovich:10.0-MIG-document_page_approval
Apr 24, 2018
Merged

[IMP][10.0][document_page_approval] Change Requests and workflow improvements on documents (#155)#160
max3903 merged 1 commit into
OCA:10.0from
ivantodorovich:10.0-MIG-document_page_approval

Conversation

@ivantodorovich

@ivantodorovich ivantodorovich commented Apr 13, 2018

Copy link
Copy Markdown
Contributor

Mig #155 to 10.0 (2/2)

Depends on #159

@ivantodorovich ivantodorovich changed the title [10.0][MIG][document_page_approval] Change Requests and workflow improvements on documents (#155) [MIG][10.0][document_page_approval] Change Requests and workflow improvements on documents (#155) Apr 13, 2018
@max3903 max3903 added this to the 10.0 milestone Apr 13, 2018
@ivantodorovich ivantodorovich changed the title [MIG][10.0][document_page_approval] Change Requests and workflow improvements on documents (#155) [IMP][10.0][document_page_approval] Change Requests and workflow improvements on documents (#155) Apr 13, 2018

@dreispt dreispt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about keeping the workflow engine, but that's only blocking for v11.
LGTM.

@max3903

max3903 commented Apr 16, 2018

Copy link
Copy Markdown
Member

@ivantodorovich Can you please rebase?

@ivantodorovich

Copy link
Copy Markdown
Contributor Author

Done!

@ivantodorovich

ivantodorovich commented Apr 24, 2018

Copy link
Copy Markdown
Contributor Author

I'm concerned that, if this does not get merged, document_page_approval will be failing for anyone cloning this branch, because #159 is already merged

@max3903 max3903 merged commit 0dca632 into OCA:10.0 Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants