[MIG] document_page_approval#122
Conversation
max3903
force-pushed
the
10.0-document_page_approval
branch
from
d7392de to
c95ce9e
Compare
|
@eugen-don or @LeartS any of you can review this pull request? Thanks! |
LeartS
left a comment
LeartS
left a comment
There was a problem hiding this comment.
Quick code review, looks good 👍
| <field name="email_to">${object.get_approvers_email}</field> | ||
| <field name="model_id" ref="model_document_page_history"/> | ||
| <field name="auto_delete" eval="True"/> | ||
| <field name="lang">${object.create_uid.partner_id.lang}</field> |
There was a problem hiding this comment.
Shouldn't it be in the approver language, not the page author's one?
There was a problem hiding this comment.
@LeartS There could be many approvers with different languages. If they need to approve the content, I assumed they can at least read in the language of the creator.
There was a problem hiding this comment.
Yes, the creator language is definitely ok too, I was just wondering if there was a way to send each mail in the recipient language (isn't there a way to get the recipient in the evaluation context / variables?).
Also note that the author language is not necessarily the document language, imagine for example a global company where each employee sets their own language in their preferences, but they all contribute to documentation in english.
Anyway, I'm nitpicking. The author language is ok.
|
seems youre all done with this. sorry for the late notice... |
4 participants
Uh oh!
There was an error while loading. Please reload this page.