Skip to content

feat(skin): add light-mode skins + skin-aware completion menus - #9461

Merged
teknium1 merged 2 commits into
mainfrom
hermes/hermes-2d398d87
Apr 14, 2026
Merged

feat(skin): add light-mode skins + skin-aware completion menus#9461
teknium1 merged 2 commits into
mainfrom
hermes/hermes-2d398d87

Conversation

@teknium1

Copy link
Copy Markdown
Collaborator

Summary

Adds two built-in light-mode skins and makes completion menu / status bar backgrounds skin-configurable. Fixes the CLI being unreadable on light terminal backgrounds.

What changed

From PR #9369 (chongweiliu):

  • daylight skin — Tailwind CSS-inspired blue/slate palette for light terminals (#111827 near-black text, #2563EB blue accents)
  • 6 new skin color keys: completion_menu_bg, completion_menu_current_bg, completion_menu_meta_bg, completion_menu_meta_current_bg, status_bar_bg, voice_status_bg
  • Makes _DIM skin-aware in cli.py (was hardcoded \033[2m, now reads banner_dim from skin)
  • Refactors _hex_to_ansi_bold()_hex_to_ansi(bold=False) so bold is optional
  • Status bar + voice status prompt_toolkit style classes
  • Tests and docs

From PR #4811 (ygd58):

  • warm-lightmode skin — warm brown/parchment tones for light terminals (#2C1810 dark brown text, #8B4513 saddle brown accents)
  • Extended with completion menu + status bar color keys for full light-mode support

How to use

/skin daylight        # cool blue/slate
/skin warm-lightmode  # warm brown/parchment

Or in ~/.hermes/config.yaml:

display:
  skin: daylight

Test plan

  • 29 skin engine tests pass (27 existing + 2 new)
  • Both skins verified: dark text, light completion menus, skin-aware status bars
  • Pre-existing test failures in auth/env/web_server are unrelated

Attribution

Cherry-picked from PR #9369 by @chongweiliu (original commit preserved).
Warm-lightmode skin adapted from PR #4811 by @ygd58.

Closes #9369, closes #4811. Also supersedes #5353, #8679, #8567.

chongweiliu and others added 2 commits April 13, 2026 23:18
Add a second light-mode skin option with warm brown/parchment tones,
adapted from ygd58's contribution in PR #4811. Includes completion
menu and status bar color keys for full light-terminal support.

Co-authored-by: buray <78954051+ygd58@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants