Skip to content

fix(tts): make schema default output path profile-safe - #7732

Closed
276970789 wants to merge 1 commit into
NousResearch:mainfrom
276970789:fix/tts-schema-default-path
Closed

fix(tts): make schema default output path profile-safe#7732
276970789 wants to merge 1 commit into
NousResearch:mainfrom
276970789:fix/tts-schema-default-path

Conversation

@276970789

Copy link
Copy Markdown

Fixes #7697

What changed

  • Make text_to_speech schema output_path default path hint HERMES_HOME/profile-aware.
  • Add a unit test to prevent hardcoded ~/.hermes defaults in schema strings.

How to test

pytest tests/tools/test_tts_schema_paths.py -q

@teknium1

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! This fix has already landed on main via #10285 (commit 722331a57).

  • tools/tts_tool.py line 1499: the output_path schema description now uses display_hermes_home() instead of a hardcoded ~/.hermes, exactly as proposed here.
  • The display_hermes_home import is present at line 44 of the same file.

The regression test file (tests/tools/test_tts_schema_paths.py) from this PR was not included in that earlier commit. If you'd like to open a focused follow-up PR adding just the test, that would be a welcome addition.

This is an automated hermes-sweeper review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

text_to_speech schema hardcodes ~/.hermes default path (misleading with HERMES_HOME / profiles)

2 participants