fix(terminal): guard invalid command values - #6417
Merged
Merged
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of #6371 by @helix4u — cherry-picked onto current main.
Prevents the terminal tool from double-faulting when an invalid
commandvalue reaches execution. When the model sendscommand: null(or omits the key), the agent crashed in two cascading places:_transform_sudo_command()calledre.search(..., command)onNone→ TypeErrorcommand[:200]onNone→ second TypeError, killing the error handlerThis caused the agent to stop working suddenly with no recovery.
Changes
terminal_tool()— returns clean error JSON_safe_command_preview()helper so retry/error logging never assumes a sliceable string_transform_sudo_command()return cleanly forNonetests/tools/test_terminal_none_command_guard.pyTest results
terminal_tool(None)returns clean error, normal commands unaffectedCredit to @helix4u for the fix.