fix(security): catch sensitive path writes in approval checks - #3859
Merged
Conversation
3 tasks
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…search#3859) Co-authored-by: Gutslabs <gutslabsxyz@gmail.com>
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…search#3859) Co-authored-by: Gutslabs <gutslabsxyz@gmail.com>
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…search#3859) Co-authored-by: Gutslabs <gutslabsxyz@gmail.com>
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…search#3859) Co-authored-by: Gutslabs <gutslabsxyz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #1934 by @Gutslabs onto current main.
Summary
Extends dangerous command detection to catch writes to sensitive paths via shell variable expansions (
$HOME,$HERMES_HOME,${HOME}) and redirect operators (>,>>).Previously missed (now caught)
echo x | tee $HERMES_HOME/.envecho x | tee "$HERMES_HOME/.env"echo x > $HERMES_HOME/.envcat key >> $HOME/.ssh/authorized_keyscat key >> ~/.ssh/authorized_keysChanges
_SENSITIVE_WRITE_TARGETregex covering/etc/,/dev/sd, SSH paths (~/.ssh/,$HOME/.ssh/), and HERMES.env(~/.hermes/.env,$HOME/.hermes/.env,$HERMES_HOME/.env)teepattern to use consolidated target>/>>writes to sensitive pathsTesting
Original PR: #1934 by @Gutslabs — cherry-picked with authorship preserved.