fix: ensure tool schema always includes name field - #3811
Merged
Conversation
When a tool plugin registers a schema without an explicit 'name' key,
get_definitions() crashes with KeyError:
available_tool_names = {t["function"]["name"] for t in filtered_tools}
Fix: always merge entry.name into schema so 'name' is never missing.
Refs: #3729
This was referenced Mar 29, 2026
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…NousResearch#3811) When a tool plugin registers a schema without an explicit 'name' key, get_definitions() crashes with KeyError: available_tool_names = {t["function"]["name"] for t in filtered_tools} Fix: always merge entry.name into schema so 'name' is never missing. Refs: NousResearch#3729 Co-authored-by: ekkoitac <ekko.itac@gmail.com>
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…NousResearch#3811) When a tool plugin registers a schema without an explicit 'name' key, get_definitions() crashes with KeyError: available_tool_names = {t["function"]["name"] for t in filtered_tools} Fix: always merge entry.name into schema so 'name' is never missing. Refs: NousResearch#3729 Co-authored-by: ekkoitac <ekko.itac@gmail.com>
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…NousResearch#3811) When a tool plugin registers a schema without an explicit 'name' key, get_definitions() crashes with KeyError: available_tool_names = {t["function"]["name"] for t in filtered_tools} Fix: always merge entry.name into schema so 'name' is never missing. Refs: NousResearch#3729 Co-authored-by: ekkoitac <ekko.itac@gmail.com>
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…NousResearch#3811) When a tool plugin registers a schema without an explicit 'name' key, get_definitions() crashes with KeyError: available_tool_names = {t["function"]["name"] for t in filtered_tools} Fix: always merge entry.name into schema so 'name' is never missing. Refs: NousResearch#3729 Co-authored-by: ekkoitac <ekko.itac@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures
get_definitions()always includes thenamefield in tool schemas, using the registeredentry.nameas authoritative source. Prevents KeyError crash when plugins or external tools register schemas without a name key.Cherry-picked from PR #3740 by @ekkoitac. Closes #3729.
Supersedes #3730, #3744, #3762 (all fix the same issue — this is the smallest/cleanest approach).