ci: exclude live integration tests from PR CI - #25367
Closed
sabnanikl-dev wants to merge 3 commits into
Closed
Conversation
- Add lint.yml (ruff check + format + pyright) - Add test.yml (pytest + coverage) - Add nightly.yml (full tests + pip-audit) - Add installation.yml (package install + import test) - Configure ruff, pyright, pytest, coverage in pyproject.toml - Add uv.lock for reproducible builds - Update .gitignore for build/coverage artifacts
- Auto-format 113 files with ruff (import sorting + black-compatible style) - Fix undefined variable in docker.py (effective_image -> image) - Fix type reassignment in hermes_cli/config.py (value -> converted) - Add Optional[SessionSource] annotation in gateway/platforms/base.py - Add proc.stdout null guards in docker/local/singularity/ssh environments - Add TYPE_CHECKING import for PatchResult in patch_parser.py
alt-glitch
added
type/test
austinpickett
requested changes
May 19, 2026
austinpickett
left a comment
austinpickett
left a comment
Collaborator
There was a problem hiding this comment.
Please fix merge conflicts and use .github/PULL_REQUEST_TEMPLATE.md
Contributor
|
This looks implemented on current main now. Automated hermes-sweeper review evidence:
Thanks for the follow-up from #29. The specific CI guard requested here has landed on main, so this PR can be closed as already implemented. |
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to closed PR #29 and Codex review comment.
This adds the CI guard for live agent/API tests so the proposed PR test workflow does not run non-hermetic
BatchRunnertests by default.Changes
integrationmarker from regular PR CI withpytest -m "not integration"integrationpytest marker inpyproject.tomltests/test_checkpoint_resumption.pyas integration-only and skips it unlessRUN_LIVE_AGENT_TESTS=1Validation
.github/workflows/test.ymlas YAML successfullyuv run ruff check tests/test_checkpoint_resumption.pyuv run ruff format --check tests/test_checkpoint_resumption.pyuv run pytest -m "not integration" tests/test_checkpoint_resumption.py -qreturns exit 5 because all 3 tests are deselected, as expected for this targeted fileuv run pytest tests/test_checkpoint_resumption.py -qreports3 skippedwithout live env opt-inNotes
This branch is based on PR #29's
feature/ci-cd-pipelinework plus the reviewer fix. PR #29 itself is closed and upstream branch push was denied for my account, so this is submitted from a fork branch.