fix(skills_guard): agent-created dangerous skills ask instead of block - #2446
Merged
Conversation
Changes the policy for agent-created skills with critical security findings from 'block' (silently rejected) to 'ask' (allowed with warning logged). The agent created the skill, so blocking it entirely is too aggressive — let it through but log the findings. - Policy: agent-created dangerous changed from block to ask - should_allow_install returns None for 'ask' (vs True/False) - format_scan_report shows 'NEEDS CONFIRMATION' for ask - skill_manager_tool.py caller handles None (allows with warning) - force=True still overrides as before Based on PR #2271 by redhelix (closed — 3200 lines of unrelated Mission Control code excluded).
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
NousResearch#2446) fix(skills_guard): agent-created dangerous skills ask instead of block
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
NousResearch#2446) fix(skills_guard): agent-created dangerous skills ask instead of block
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
NousResearch#2446) fix(skills_guard): agent-created dangerous skills ask instead of block
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
NousResearch#2446) fix(skills_guard): agent-created dangerous skills ask instead of block
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
NousResearch#2446) fix(skills_guard): agent-created dangerous skills ask instead of block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of PR #2271 by @redhelix — skills_guard change only (Mission Control adapter excluded as unrelated).
Agent-created skills with critical security findings were silently blocked. Now they're allowed with a warning logged, since the agent created the skill and blocking it entirely is too aggressive.
block→askfor agent-created dangerousshould_allow_install()returnsNonefor ask (tri-state: True/None/False)format_scan_report()showsNEEDS CONFIRMATIONfor askskill_manager_tool.pycaller handlesNone— allows with warning3 files, +26/-8. 53 skills_guard tests pass.