fix(delegate): save parent tool names before child construction mutates global - #2083
Merged
teknium1 merged 1 commit intoMar 20, 2026
Conversation
ygd58
force-pushed
the
fix/delegate-save-parent-tool-names-before-child-build
branch
from
March 19, 2026 19:27
ef927ae to
816d134
Compare
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…ent-tool-names-before-child-build fix(delegate): save parent tool names before child construction mutates global
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…ent-tool-names-before-child-build fix(delegate): save parent tool names before child construction mutates global
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…ent-tool-names-before-child-build fix(delegate): save parent tool names before child construction mutates global
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ent-tool-names-before-child-build fix(delegate): save parent tool names before child construction mutates global
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…ent-tool-names-before-child-build fix(delegate): save parent tool names before child construction mutates global
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2079
Root Cause
The previous fix (#1804/#1894) moved
_saved_tool_namesinto_run_single_child()to fix the NameError, but the save still captured the wrong value._build_child_agent()callsAIAgent()which callsget_tool_definitions(), which overwritesmodel_tools._last_resolved_tool_nameswith the child's toolset. By the time_run_single_child()saves the global, it's already the child's tools — not the parent's.Fix
delegate_task()at the top of the build loopchild._delegate_saved_tool_names = _parent_tool_names_model_tools._last_resolved_tool_names = _parent_tool_names_run_single_childnow reads fromchild._delegate_saved_tool_names(correct parent value)Fixes Both Cases