fix(matrix): use correct reply_to_message_id parameter name - #1895
Merged
Conversation
Fixes #1842 The MessageEvent dataclass expects 'reply_to_message_id' but the Matrix connector was passing 'reply_to'. This caused replies to fail with: MessageEvent.__init__() got an unexpected keyword argument 'reply_to' Changed the parameter name to match the dataclass definition.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…arch#1895) fix(matrix): use correct reply_to_message_id parameter name
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…arch#1895) fix(matrix): use correct reply_to_message_id parameter name
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…arch#1895) fix(matrix): use correct reply_to_message_id parameter name
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…arch#1895) fix(matrix): use correct reply_to_message_id parameter name
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…arch#1895) fix(matrix): use correct reply_to_message_id parameter name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks PR #1885 by @Bartok9. Fixes #1842.
Matrix adapter was passing
reply_to=reply_totoMessageEvent, but the dataclass field isreply_to_message_id. Every other adapter uses the correct name. This caused Matrix replies to crash.Supersedes #1885.