fix(state): add missing thread locks to 4 SessionDB methods - #1704
Merged
Conversation
search_sessions(), clear_messages(), delete_session(), and prune_sessions() all accessed self._conn without acquiring self._lock. Every other method in the class uses the lock. In multi-threaded contexts (gateway serving concurrent platform messages), these unprotected methods can cause sqlite3.ProgrammingError from concurrent cursor operations on the same connection.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…te-thread-locks fix(state): add missing thread locks to 4 SessionDB methods
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…te-thread-locks fix(state): add missing thread locks to 4 SessionDB methods
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…te-thread-locks fix(state): add missing thread locks to 4 SessionDB methods
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…te-thread-locks fix(state): add missing thread locks to 4 SessionDB methods
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…te-thread-locks fix(state): add missing thread locks to 4 SessionDB methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four
SessionDBmethods accessedself._connwithout acquiringself._lock, while every other method in the class consistently uses the lock:search_sessions()— reads sessions tableclear_messages()— deletes messages + updates session counters + commitsdelete_session()— checks existence + deletes messages + deletes session + commitsprune_sessions()— selects old sessions + deletes messages + deletes sessions + commitsIn the gateway's multi-threaded context (concurrent messages from different platforms/users), these unprotected methods can cause
sqlite3.ProgrammingErrorfrom concurrent cursor operations on the same connection.What changed
hermes_state.py: Wrapped each method body inwith self._lock:Test plan
python -m pytest tests/test_hermes_state.py -n0 -q→ 109 passed ✔