fix(gateway): PII redaction config never read — missing yaml import - #1701
Merged
Conversation
The privacy.redact_pii config reader on line 1546 used bare 'yaml' which is not in scope — yaml is imported as '_yaml' at module level (line 93) and as '_y' in other methods. The NameError was silently caught by the try/except, so PII redaction never activated even when configured. Add a local 'import yaml as _pii_yaml' consistent with the pattern used elsewhere in the file.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…ml-pii-redaction fix(gateway): PII redaction config never read — missing yaml import
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…ml-pii-redaction fix(gateway): PII redaction config never read — missing yaml import
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…ml-pii-redaction fix(gateway): PII redaction config never read — missing yaml import
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…ml-pii-redaction fix(gateway): PII redaction config never read — missing yaml import
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…ml-pii-redaction fix(gateway): PII redaction config never read — missing yaml import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
privacy.redact_piiconfig reader ingateway/run.pyline 1546 used bareyaml.safe_load(), butyamlis not in scope at that point — the module-level import isimport yaml as _yaml(line 93), and other methods use localimport yaml as _y.The
NameErrorwas silently caught by thetry/except Exception: passblock, so_redact_piialways defaulted toFalse. Users who configuredprivacy.redact_pii: truegot no PII redaction in the gateway.What changed
gateway/run.py: Added localimport yaml as _pii_yamlbefore the safe_load call, consistent with the aliased-import pattern used throughout the file.Test plan
privacy.redact_pii: truein config.yaml