feat(voice): add CLI record beep toggle - #13247
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
voice.beep_enabledconfig toggle for CLI voice mode so users can disable the record start/stop beeps without turning voice mode off entirely.This keeps the existing behavior by default, but removes an annoying hardcoded audio cue for users who use
/voiceheavily or in quieter/shared environments.Related Issue
Fixes #
Type of Change
Changes Made
voice.beep_enabledtoDEFAULT_CONFIGand bumped_config_versioninhermes_cli/config.pyHermesCLI._voice_beeps_enabled()and gated both CLI voice beeps incli.pytests/tools/test_voice_cli_integration.pywebsite/docs/user-guide/features/voice-mode.mdwebsite/docs/user-guide/configuration.mdwebsite/docs/guides/use-voice-mode-with-hermes.mdHow to Test
voice.beep_enabled: falsein~/.hermes/config.yaml, restart the CLI, and verify/voicerecording starts and stops silently.source venv/bin/activate && scripts/run_tests.sh tests/tools/test_voice_cli_integration.py tests/tools/test_voice_mode.pyand confirm the focused voice suite passes.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Focused test run:
Full suite run:
Current unrelated full-suite failures observed during the full run: