fix(setup): remove dead code causing is_coding_plan NameError crash - #1123
Merged
teknium1 merged 1 commit intoMar 13, 2026
Merged
Conversation
Remove 50 lines of unreachable duplicate model selection logic in setup_model_provider() for zai/kimi-coding/minimax/minimax-cn providers. The code referenced undefined `is_coding_plan` variable, crashing setup. _setup_provider_model_selection() already handles these providers correctly via _DEFAULT_PROVIDER_MODELS dict.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…plan-nameError Clean fix — removes dead code that crashed with NameError on is_coding_plan. The generic _setup_provider_model_selection() already handles all affected providers.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…plan-nameError Clean fix — removes dead code that crashed with NameError on is_coding_plan. The generic _setup_provider_model_selection() already handles all affected providers.
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…plan-nameError Clean fix — removes dead code that crashed with NameError on is_coding_plan. The generic _setup_provider_model_selection() already handles all affected providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup_model_provider()that referenced an undefinedis_coding_planvariable, causing aNameErrorcrash when selectingzai,kimi-coding,minimax, orminimax-cnproviders_setup_provider_model_selection()function already handles all these providers correctly via_DEFAULT_PROVIDER_MODELSdict — the removed code was leftover from before this generic function was introducedRemoved dead code
The removed block (lines 1246-1295) contained:
is_coding_plan— never defined insetup_model_provider()scope, crashes with NameError_DEFAULT_PROVIDER_MODELS["zai"]elifbranches forkimi-codingandminimax— already caught by the parent conditionTest plan