Initial WebAssembly/WASI cross-compilation support - #56555
Conversation
ElvishJerricco
left a comment
There was a problem hiding this comment.
Just took a cursory glance. Will do a more in depth review tomorrow.
In general though, this looks like several PRs in one. Stuff like the new version of llvm and the V8 changes seem like they should be different PRs to get better review.
|
Yeah good point, i can split into llvm8 init, wasm init, and the v8 update. |
73649a0 to
7df1640
Compare
|
this looks really cool! |
|
This should probably switch to https://github.com/CraneStation/wasi-sysroot for |
|
@ElvishJerricco Yeah i agree on that. Ideally the jfbastien and webghc musl stuff could be upstreamed. But right now that's not really a real ABI. Luckily we can reuse most of the changes here though. |
76ece4a to
fd5a881
Compare
|
@GrahamcOfBorg eval |
|
WOOHOOO! Awesome work! \o/
…On Tue, 23 Apr 2019 19:44:42 -0700, Matthew Bauer ***@***.***> wrote:
Merged #56555 into staging.
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#56555 (comment) part: text/html
|
Motivation for this change
Need to add LLVM 8 to get this working. Can compile basic C programs. Things like C++ are unfortunately not supported right now.
/cc @ElvishJerricco
Test case:
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)