Appropriate exclusion of rl-next.md when officialRelease = true#16154
Open
aetosdios27 wants to merge 1 commit into
Open
Appropriate exclusion of rl-next.md when officialRelease = true#16154aetosdios27 wants to merge 1 commit into
aetosdios27 wants to merge 1 commit into
Conversation
Assisted-by: Codex (GPT-5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
officialReleaseflag is supposed to excluderl-next.mdfrom official manual builds. However, the upcoming-release entry was still included whenofficialRelease = true.Context
The summary-generation step did not check the
officialReleaseflag directly. Instead, it checked whether the generated input file existed. Meson materialized that file even for official releases, so the check succeeded and included the upcoming-release entry.This change checks the release mode directly when deciding whether to include the entry.
Closes #16135