Update OpenAPI client and extend mypy checks - #42
Merged
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 79.80% 79.31% -0.50%
==========================================
Files 782 782
Lines 13712 13382 -330
==========================================
- Hits 10943 10614 -329
+ Misses 2769 2768 -1
☔ View full report in Codecov by Sentry. |
robin-nitrokey
force-pushed
the
update-openapi
branch
2 times, most recently
from
October 17, 2023 20:24
53d0ae6 to
8d2b11d
Compare
This patch updates the OpenAPI client using the generator version 3.1.1. It also removes the mypy config that ignored errors for the generated code as the new generator version fixes the mypy issues in it. Fixes: #39
robin-nitrokey
force-pushed
the
update-openapi
branch
from
October 17, 2023 20:26
8d2b11d to
b65d6a9
Compare
robin-nitrokey
marked this pull request as ready for review
October 17, 2023 20:26
robin-nitrokey
requested review from
daringer,
q-nk,
sosthene-nitrokey and
szszszsz
October 17, 2023 20:26
q-nk
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates the OpenAPI client using the generator version 3.1.1.
It also removes the mypy config that ignored errors for the generated
code as the new generator version fixes the mypy issues in it.
Fixes: #39