Skip to content

Update OpenAPI client and extend mypy checks - #42

Merged
robin-nitrokey merged 1 commit into
mainfrom
update-openapi
Oct 18, 2023
Merged

Update OpenAPI client and extend mypy checks #42
robin-nitrokey merged 1 commit into
mainfrom
update-openapi

Conversation

@robin-nitrokey

@robin-nitrokey robin-nitrokey commented Oct 12, 2023

Copy link
Copy Markdown
Member

This patch updates the OpenAPI client using the generator version 3.1.1.
It also removes the mypy config that ignored errors for the generated
code as the new generator version fixes the mypy issues in it.

Fixes: #39

@codecov

codecov Bot commented Oct 12, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (f9006e6) 79.80% compared to head (b65d6a9) 79.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   79.80%   79.31%   -0.50%     
==========================================
  Files         782      782              
  Lines       13712    13382     -330     
==========================================
- Hits        10943    10614     -329     
+ Misses       2769     2768       -1     
Files Coverage Δ
nethsm/client/api_response.py 100.00% <100.00%> (ø)
...ient/components/schema/backup_passphrase_config.py 87.50% <ø> (ø)
nethsm/client/components/schema/decrypt_data.py 75.00% <ø> (ø)
...m/client/components/schema/decrypt_request_data.py 78.26% <100.00%> (ø)
...m/client/components/schema/encrypt_request_data.py 78.26% <100.00%> (ø)
...thsm/client/components/schema/health_state_data.py 71.87% <ø> (ø)
nethsm/client/components/schema/info_data.py 72.22% <100.00%> (ø)
...ent/components/schema/key_generate_request_data.py 74.24% <100.00%> (ø)
nethsm/client/components/schema/key_item.py 71.87% <ø> (ø)
...ethsm/client/components/schema/key_private_data.py 66.07% <100.00%> (ø)
... and 289 more

... and 89 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robin-nitrokey
robin-nitrokey force-pushed the update-openapi branch 2 times, most recently from 53d0ae6 to 8d2b11d Compare October 17, 2023 20:24
@robin-nitrokey robin-nitrokey changed the title wip: Update client, extend mypy checks Update OpenAPI client and extend mypy checks Oct 17, 2023
This patch updates the OpenAPI client using the generator version 3.1.1.
It also removes the mypy config that ignored errors for the generated
code as the new generator version fixes the mypy issues in it.

Fixes: #39
@robin-nitrokey
robin-nitrokey marked this pull request as ready for review October 17, 2023 20:26
@robin-nitrokey
robin-nitrokey merged commit 08a2a10 into main Oct 18, 2023
@robin-nitrokey
robin-nitrokey deleted the update-openapi branch October 18, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update OpenAPI generator

2 participants