[codex] align docs with OpenRouter and polymorph domain - #232
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthroughThis PR updates the production app URL to ChangesProduction URL Migration and Architectural Documentation Sync
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Trivy (0.69.3)Trivy execution failed: 2026-05-27T02:11:45Z FATAL Fatal error run error: fs scan error: scan error: scan failed: failed analysis: post analysis error: post analysis error: helm scan error: fs filter error: fs filter error: walk error range error: stat .coderabbit-opengrep-fallback.yml: no such file or directory: range error: stat .coderabbit-opengrep-fallback.yml: no such file or directory Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NickB03
marked this pull request as ready for review
May 27, 2026 02:10
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (5)
docs/superpowers/plans/2026-05-19-bklit-charts-in-admin-evals.md (1)
3-4: 💤 Low valueMarkdownlint rule violation: blank line inside blockquote.
The blank line at line 4 between two blockquotes violates MD028 (no-blanks-blockquote). Same formatting pattern across multiple plan documents in this layer.
Fix for markdownlint MD028 violation
Remove the blank line between blockquotes:
> **Status:** Completed historical plan. Gauge, area, and radar chart work is already wired into the admin evals dashboard; use this document for implementation history only. - > **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.As per coding guidelines: Prettier formatting with LF line endings applies to all
**/*.mdfiles.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/superpowers/plans/2026-05-19-bklit-charts-in-admin-evals.md` around lines 3 - 4, Remove the blank line between consecutive blockquote lines to satisfy markdownlint MD028: locate the blockquote starting with "> **Status:** Completed historical plan." and the following blockquote and delete the empty line between them so they are adjacent; apply the same fix to other plan documents with the same pattern, then run Prettier to ensure LF line endings and overall formatting consistency.docs/superpowers/plans/2026-04-30-evals-dashboard-ia-migration.md (1)
3-4: 💤 Low valueMarkdownlint rule violation: blank line inside blockquote.
The blank line at line 4 between the status blockquote and the worker instructions blockquote violates MD028 (no-blanks-blockquote). To fix, either merge these into a single blockquote or remove the blank line.
Fix for markdownlint MD028 violation
Option 1 - Remove the blank line:
> **Status:** Completed historical plan. `/admin/evals` now uses the dashboard-v2 IA; use this document for implementation history only, not as current work instructions. - > **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.Option 2 - Merge into single blockquote:
-> **Status:** Completed historical plan. `/admin/evals` now uses the dashboard-v2 IA; use this document for implementation history only, not as current work instructions. +> **Status:** Completed historical plan. `/admin/evals` now uses the dashboard-v2 IA; use this document for implementation history only, not as current work instructions. +> +> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.As per coding guidelines: Prettier formatting with LF line endings applies to all
**/*.mdfiles.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/superpowers/plans/2026-04-30-evals-dashboard-ia-migration.md` around lines 3 - 4, The MD028 violation is caused by a blank line inside the blockquote between the "**Status:** Completed historical plan..." line and the following worker-instructions blockquote; fix it by either removing the blank line so both blockquote lines are contiguous or by merging the two blockquote sections into a single blockquote paragraph in the file docs/superpowers/plans/2026-04-30-evals-dashboard-ia-migration.md, ensuring the result passes markdownlint and Prettier (LF) formatting.docs/superpowers/plans/2026-05-05-evals-phoenix-insight-suite-focus.md (1)
3-4: 💤 Low valueMarkdownlint rule violation: blank line inside blockquote.
The blank line at line 4 between two blockquotes violates MD028 (no-blanks-blockquote). Same issue as in the evals-dashboard-ia-migration.md file.
Fix for markdownlint MD028 violation
Remove the blank line between blockquotes:
> **Status:** Completed historical plan, later superseded by the current dashboard-v2 attention helper. References to `phoenix-insight.tsx` describe a removed intermediate component. - > **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.As per coding guidelines: Prettier formatting with LF line endings applies to all
**/*.mdfiles.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/superpowers/plans/2026-05-05-evals-phoenix-insight-suite-focus.md` around lines 3 - 4, The MD028 markdownlint violation is caused by a blank line inside the blockquote between the lines that start with "**Status:** Completed historical plan, later superseded by the current dashboard-v2 attention helper." and "References to `phoenix-insight.tsx` describe a removed intermediate component."; remove the blank line so the two blockquote lines are contiguous (no empty line between them) and reformat to match Prettier LF rules for .md files.docs/superpowers/plans/2026-05-06-prompt-injection-protection.md (1)
3-4: 💤 Low valueMarkdownlint rule violation: blank line inside blockquote.
The blank line at line 4 between two blockquotes violates MD028 (no-blanks-blockquote). Same issue pattern across multiple plan documents.
Fix for markdownlint MD028 violation
Remove the blank line between blockquotes:
> **Status:** Active proposal, not implemented. Revalidate source paths and current protections before execution: the continuation validation path has moved, and the CSP/search/fetch/eval protections proposed here are not currently shipped. - > **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.As per coding guidelines: Prettier formatting with LF line endings applies to all
**/*.mdfiles.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/superpowers/plans/2026-05-06-prompt-injection-protection.md` around lines 3 - 4, Remove the stray blank line between consecutive blockquote lines that triggers markdownlint MD028 in the plan document (the blank line between the two leading "> " lines in the quoted status text); update the file to collapse adjacent blockquotes into contiguous lines with no empty line between them, apply Prettier formatting with LF line endings, and sweep other plan documents for the same pattern to ensure no other MD028 violations remain.docs/superpowers/plans/2026-05-20-tool-selection-evaluator.md (1)
3-4: 💤 Low valueMarkdownlint rule violation: blank line inside blockquote.
The blank line at line 4 between two blockquotes violates MD028 (no-blanks-blockquote). This is the sixth occurrence of the same pattern across the plan documents in this PR.
Fix for markdownlint MD028 violation
Remove the blank line between blockquotes:
> **Status:** Completed historical plan with one operational caveat: the evaluator and dashboard labels are implemented, but judge validation against live/human-labeled production calls should be tracked in an active runbook if it is still required. - > **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.As per coding guidelines: Prettier formatting with LF line endings applies to all
**/*.mdfiles.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/superpowers/plans/2026-05-20-tool-selection-evaluator.md` around lines 3 - 4, Remove the stray blank line between adjacent blockquote lines in the plan header (the line after "**Status:** Completed..." that created an empty blockquote), so the two blockquote lines are contiguous and MD028 is satisfied; then reformat the file with Prettier (LF endings) to ensure markdownlint rules are enforced.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/plans/admin-evals-polish.md`:
- Around line 3-4: Remove the blank line inside the blockquote that begins with
"**Status:** Completed historical plan." in docs/plans/admin-evals-polish.md so
the blockquote has no empty lines between its lines (fixes markdownlint
MD028/no-blanks-blockquote); edit the blockquote content to be contiguous text
without any blank line separators.
In `@docs/superpowers/plans/2026-04-20-geo-map-tier-2-expansion.md`:
- Around line 3-4: The blockquote in the document contains an internal blank
line that triggers markdownlint MD028; edit the blockquote so there are no blank
lines between lines that begin with ">" (i.e., collapse the two separate ">"
paragraphs into a single contiguous blockquote), ensuring each quoted line
starts with ">" and there are no empty ">" lines inside the blockquote.
In
`@docs/superpowers/plans/2026-04-23-ai-sdk-contract-standardization-phase-2.md`:
- Around line 3-4: Remove the blank line inside the blockquote so the blockquote
uses consecutive '>' lines without an empty '>' line; locate the block
containing the line that starts with "> **Status:** Completed historical
plan..." and delete the empty line between the blockquote lines so markdownlint
MD028 is no longer triggered.
In `@docs/superpowers/plans/2026-04-23-pr-171-ai-sdk-contract-remediation.md`:
- Around line 3-4: Remove the stray blank line inside the opening blockquote to
satisfy markdownlint MD028: edit the callout that begins with "**Status:**
Historical PR remediation plan. The referenced PR and source ownership have
moved on; use this document only for review history." so the two blockquote
lines are contiguous (no empty line between them), resulting in a single
continuous blockquote.
In `@SECURITY.md`:
- Line 47: Update the SECURITY.md line about eval_summaries and
eval_case_results to explicitly state the RLS policy: specify whether rows are
readable by any authenticated app session or restricted to the admin identity
only (e.g., the user matching ADMIN_USER_ID via isAdminUserId(user.id)); change
the sentence to state the exact rule (for example, "readable only to admin user
where isAdminUserId(user.id) is true" or "readable to all authenticated app
sessions (any logged-in user)"), and if needed add a short note linking this to
the admin route requirement (isAdminUserId and ADMIN_USER_ID) so readers know
which policy applies.
---
Nitpick comments:
In `@docs/superpowers/plans/2026-04-30-evals-dashboard-ia-migration.md`:
- Around line 3-4: The MD028 violation is caused by a blank line inside the
blockquote between the "**Status:** Completed historical plan..." line and the
following worker-instructions blockquote; fix it by either removing the blank
line so both blockquote lines are contiguous or by merging the two blockquote
sections into a single blockquote paragraph in the file
docs/superpowers/plans/2026-04-30-evals-dashboard-ia-migration.md, ensuring the
result passes markdownlint and Prettier (LF) formatting.
In `@docs/superpowers/plans/2026-05-05-evals-phoenix-insight-suite-focus.md`:
- Around line 3-4: The MD028 markdownlint violation is caused by a blank line
inside the blockquote between the lines that start with "**Status:** Completed
historical plan, later superseded by the current dashboard-v2 attention helper."
and "References to `phoenix-insight.tsx` describe a removed intermediate
component."; remove the blank line so the two blockquote lines are contiguous
(no empty line between them) and reformat to match Prettier LF rules for .md
files.
In `@docs/superpowers/plans/2026-05-06-prompt-injection-protection.md`:
- Around line 3-4: Remove the stray blank line between consecutive blockquote
lines that triggers markdownlint MD028 in the plan document (the blank line
between the two leading "> " lines in the quoted status text); update the file
to collapse adjacent blockquotes into contiguous lines with no empty line
between them, apply Prettier formatting with LF line endings, and sweep other
plan documents for the same pattern to ensure no other MD028 violations remain.
In `@docs/superpowers/plans/2026-05-19-bklit-charts-in-admin-evals.md`:
- Around line 3-4: Remove the blank line between consecutive blockquote lines to
satisfy markdownlint MD028: locate the blockquote starting with "> **Status:**
Completed historical plan." and the following blockquote and delete the empty
line between them so they are adjacent; apply the same fix to other plan
documents with the same pattern, then run Prettier to ensure LF line endings and
overall formatting consistency.
In `@docs/superpowers/plans/2026-05-20-tool-selection-evaluator.md`:
- Around line 3-4: Remove the stray blank line between adjacent blockquote lines
in the plan header (the line after "**Status:** Completed..." that created an
empty blockquote), so the two blockquote lines are contiguous and MD028 is
satisfied; then reformat the file with Prettier (LF endings) to ensure
markdownlint rules are enforced.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f3cbe573-4656-4c3e-a0eb-47dac7e36400
⛔ Files ignored due to path filters (4)
docs/assets/architecture-dark.pngis excluded by!**/*.pngdocs/assets/architecture-dark.svgis excluded by!**/*.svgdocs/assets/architecture.pngis excluded by!**/*.pngdocs/assets/architecture.svgis excluded by!**/*.svg
📒 Files selected for processing (36)
.env.local.example.github/workflows/ci.yml.github/workflows/docker-build.yml.github/workflows/release.ymlDockerfileGEMINI.mdREADME.mdSECURITY.mddocs/README.mddocs/architecture/MODEL-CONFIGURATION.mddocs/architecture/OVERVIEW.mddocs/architecture/RESEARCH-AGENT.mddocs/architecture/STREAMING.mddocs/assets/architecture-mermaid.mddocs/getting-started/QUICKSTART.mddocs/operations/DEPLOYMENT.mddocs/operations/runbooks/day-2-operations.mddocs/plans/admin-evals-polish.mddocs/plans/evals-dashboard-ia-migration.mddocs/proposals/SKILLS-ROUTING.mddocs/reference/API.mddocs/reference/FILE-INDEX.mddocs/superpowers/plans/2026-04-19-canvas-code-block-diff.mddocs/superpowers/plans/2026-04-20-geo-map-tier-2-expansion.mddocs/superpowers/plans/2026-04-21-docs-accuracy-audit-plan.mddocs/superpowers/plans/2026-04-23-ai-sdk-contract-standardization-phase-1.mddocs/superpowers/plans/2026-04-23-ai-sdk-contract-standardization-phase-2.mddocs/superpowers/plans/2026-04-23-pr-171-ai-sdk-contract-remediation.mddocs/superpowers/plans/2026-04-27-ai-sdk-contract-standardization-phase-3.mddocs/superpowers/plans/2026-04-30-evals-dashboard-ia-migration.mddocs/superpowers/plans/2026-05-04-parts-table-removal.mddocs/superpowers/plans/2026-05-05-evals-phoenix-insight-suite-focus.mddocs/superpowers/plans/2026-05-06-prompt-injection-protection.mddocs/superpowers/plans/2026-05-19-bklit-charts-in-admin-evals.mddocs/superpowers/plans/2026-05-20-tool-selection-evaluator.mdlib/utils/__tests__/public-origin.test.ts
Comment on lines
+3
to
+4
| > **Status:** Completed historical plan. The polish pieces described here are already represented in the current dashboard-v2 components; use this document for implementation history only. | ||
|
|
Contributor
There was a problem hiding this comment.
Remove the blank line inside the blockquote.
This trips markdownlint MD028 (no-blanks-blockquote) and can fail doc lint pipelines.
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 4-4: Blank line inside blockquote
(MD028, no-blanks-blockquote)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/plans/admin-evals-polish.md` around lines 3 - 4, Remove the blank line
inside the blockquote that begins with "**Status:** Completed historical plan."
in docs/plans/admin-evals-polish.md so the blockquote has no empty lines between
its lines (fixes markdownlint MD028/no-blanks-blockquote); edit the blockquote
content to be contiguous text without any blank line separators.
Comment on lines
+3
to
+4
| > **Status:** Completed historical plan. Geo Tier 2 tools are already part of the current chat-agent toolset; source paths below predate the `lib/agents/chat/*` module split and should not be used as fresh execution instructions. | ||
|
|
Contributor
There was a problem hiding this comment.
Fix blockquote spacing to satisfy markdownlint.
There is a blank line inside the blockquote, which triggers MD028 (no-blanks-blockquote).
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 4-4: Blank line inside blockquote
(MD028, no-blanks-blockquote)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/superpowers/plans/2026-04-20-geo-map-tier-2-expansion.md` around lines 3
- 4, The blockquote in the document contains an internal blank line that
triggers markdownlint MD028; edit the blockquote so there are no blank lines
between lines that begin with ">" (i.e., collapse the two separate ">"
paragraphs into a single contiguous blockquote), ensuring each quoted line
starts with ">" and there are no empty ">" lines inside the blockquote.
Comment on lines
+3
to
+4
| > **Status:** Completed historical plan. Current runtime ownership lives in `lib/agents/chat/*`, and `messages.ui_message` is the canonical persistence contract; use this document only for implementation history. | ||
|
|
Contributor
There was a problem hiding this comment.
Remove the empty line within the blockquote block.
markdownlint flags this as MD028 (no-blanks-blockquote).
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 4-4: Blank line inside blockquote
(MD028, no-blanks-blockquote)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/superpowers/plans/2026-04-23-ai-sdk-contract-standardization-phase-2.md`
around lines 3 - 4, Remove the blank line inside the blockquote so the
blockquote uses consecutive '>' lines without an empty '>' line; locate the
block containing the line that starts with "> **Status:** Completed historical
plan..." and delete the empty line between the blockquote lines so markdownlint
MD028 is no longer triggered.
Comment on lines
+3
to
+4
| > **Status:** Historical PR remediation plan. The referenced PR and source ownership have moved on; use this document only for review history. | ||
|
|
Contributor
There was a problem hiding this comment.
Address markdownlint MD028 in the opening callout.
The blank line between blockquote lines should be removed to keep the blockquote contiguous.
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 4-4: Blank line inside blockquote
(MD028, no-blanks-blockquote)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/superpowers/plans/2026-04-23-pr-171-ai-sdk-contract-remediation.md`
around lines 3 - 4, Remove the stray blank line inside the opening blockquote to
satisfy markdownlint MD028: edit the callout that begins with "**Status:**
Historical PR remediation plan. The referenced PR and source ownership have
moved on; use this document only for review history." so the two blockquote
lines are contiguous (no empty line between them), resulting in a single
continuous blockquote.
| - **canvasArtifacts**, **canvasArtifactVersions** -- Access scoped to the owning user via the parent chat chain. | ||
| - **artifacts**, **artifactRevisions**, **artifactRuntimeSessions** -- Legacy artifact tables; access scoped to the owning user via the parent artifact/chat chain. | ||
| - **feedback** -- Anyone can insert feedback; all feedback is readable (no sensitive user data stored). | ||
| - **eval_summaries**, **eval_case_results** -- readable to authenticated app sessions for the admin dashboard. |
Contributor
There was a problem hiding this comment.
Clarify the RLS policy for eval tables.
The description "readable to authenticated app sessions for the admin dashboard" is ambiguous. Does this mean:
- All authenticated users can read these tables (but only admin users can view the dashboard UI)?
- Only the admin user (matching
ADMIN_USER_ID) can read these tables?
Based on line 35's description of admin routes requiring isAdminUserId(user.id), consider clarifying whether the RLS policy is authenticated-wide or admin-only.
📝 Suggested clarification
If admin-only:
-- **eval_summaries**, **eval_case_results** -- readable to authenticated app sessions for the admin dashboard.
+- **eval_summaries**, **eval_case_results** -- admin-only access for the `/admin/evals` dashboard.If authenticated-wide:
-- **eval_summaries**, **eval_case_results** -- readable to authenticated app sessions for the admin dashboard.
+- **eval_summaries**, **eval_case_results** -- readable by all authenticated users; surfaced in the admin-only `/admin/evals` dashboard.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@SECURITY.md` at line 47, Update the SECURITY.md line about eval_summaries and
eval_case_results to explicitly state the RLS policy: specify whether rows are
readable by any authenticated app session or restricted to the admin identity
only (e.g., the user matching ADMIN_USER_ID via isAdminUserId(user.id)); change
the sentence to state the exact rule (for example, "readable only to admin user
where isAdminUserId(user.id) is true" or "readable to all authenticated app
sessions (any logged-in user)"), and if needed add a short note linking this to
the admin route requirement (isAdminUserId and ADMIN_USER_ID) so readers know
which policy applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://polymorph.fyi.messages.ui_message, suggestions headers, stream metadata, eval judge credentials, and historical plan classification.Why
The documentation audit found current docs still mixed older Vercel preview-domain, AI Gateway/Grok-era provider wording, deleted
lib/agents/researcher.tsreferences, and stale operational details. This PR brings current docs back in line with the code and config source of truth.Validation
bun run test -- lib/utils/__tests__/public-origin.test.tsbun lintbun typecheckbun run format:checkgit diff --checkrg -n "polymorph-nb\.vercel\.app" --hidden --glob '!.git/**' --glob '!node_modules/**' --glob '!services/evals/node_modules/**' .returned no matchesSummary by CodeRabbit
Infrastructure & Configuration
Features
Documentation