Should correctly broadcast light transactions#9448
Merged
LukaszRozmej merged 7 commits intomasterfrom Oct 13, 2025
Merged
Conversation
marcindsobczak
approved these changes
Oct 13, 2025
Contributor
There was a problem hiding this comment.
There is no bug in production code, as we call SpecDrivenTxGossipPolicy.ShouldGossipTransaction() only with full blob transaction as an argument.
But I agree that current code is a bit misleading and it is worth to refactor it. After changes from this PR it is cleaner. There will be no change in actual behavior, but code will bo more robust
Contributor
|
This check is actually preventing us from announcing blob txs to the newly connected peer and from reannouncing after new block arrival. So it is not only refactor, it is a bug fix. |
LukaszRozmej
commented
Oct 13, 2025
| public virtual ProofVersion? GetProofVersion() => SupportsBlobs | ||
| ? this is { NetworkWrapper: ShardBlobNetworkWrapper { Version: var version } } | ||
| ? version | ||
| : ProofVersion.V0 |
Member
Author
There was a problem hiding this comment.
should this return null if no wrapper?
Contributor
There was a problem hiding this comment.
or throw an exception if no wrapper but proof version is requested?
marcindsobczak
approved these changes
Oct 13, 2025
benaadams
approved these changes
Oct 13, 2025
LukaszRozmej
deleted the
fix/light-transaction-broadcast-proof-version
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?