Conversation
cicr99
reviewed
Feb 27, 2026
cicr99
reviewed
Feb 27, 2026
cicr99
approved these changes
Feb 27, 2026
alexb5dh
reviewed
Feb 28, 2026
alexb5dh
reviewed
Feb 28, 2026
Co-authored-by: Alex <alexb5dh@gmail.com>
Co-authored-by: Alex <alexb5dh@gmail.com>
Co-authored-by: Alex <alexb5dh@gmail.com>
Co-authored-by: Alex <alexb5dh@gmail.com>
alexb5dh
approved these changes
Mar 2, 2026
Comment on lines
123
to
125
| return ExecuteSpecialTransaction(tx, tracer, opts); | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| return ExecuteSpecialTransaction(tx, tracer, opts); | |
| } | |
| return ExecuteSpecialTransaction(tx, tracer, opts); | |
| } |
| out UInt256 blobBaseFee) | ||
| { | ||
| if (tx.RequiresSpecialHandling((XdcReleaseSpec)spec)) | ||
| if (tx.RequiresSpecialHandling((XdcReleaseSpec)spec) || tx.IsSpecialTransaction((XdcReleaseSpec)spec)) |
Contributor
There was a problem hiding this comment.
To confirm - all other current calls to RequiresSpecialHandling doesn't need to account for IsSpecialTransaction?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds protocol support for syncing Xdc chain both full and fast sync.
Adds p2p messaging for XDC chain.