generators: test generator with reasoning traces - #1697
Merged
jmartin-tech merged 8 commits intoApr 30, 2026
Conversation
Signed-off-by: Leon Derczynski <lderczynski@nvidia.com>
Signed-off-by: Leon Derczynski <lderczynski@nvidia.com>
…t generator Signed-off-by: Leon Derczynski <lderczynski@nvidia.com>
Signed-off-by: Leon Derczynski <lderczynski@nvidia.com>
Signed-off-by: Leon Derczynski <lderczynski@nvidia.com>
… test output length margins Signed-off-by: Leon Derczynski <lderczynski@nvidia.com>
leondz
marked this pull request as ready for review
April 22, 2026 18:27
leondz
marked this pull request as draft
April 23, 2026 01:17
…r output length variation in chars Signed-off-by: Leon Derczynski <lderczynski@nvidia.com>
leondz
changed the title
Signed-off-by: Leon Derczynski <lderczynski@nvidia.com>
leondz
marked this pull request as ready for review
April 23, 2026 17:08
| DEFAULT_PARAMS = Lipsum.DEFAULT_PARAMS | { | ||
| "skip_seq_start": "<think>", | ||
| "skip_seq_end": "</think>", | ||
| "reasoning_length": 2000, |
Collaborator
There was a problem hiding this comment.
This is a good starting point, should this provide support to randomly consume the allowed tokens via some custom values?
For example support int values for a set number but if set to the string random consume a random number <= self.max_tokens as reasoning tokens and the leave the final response with only the remaining tokens, and maybe all to guarantee that the response text is always empty. This might simulate when the reasoning tokens consume the whole response string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to help eval downstream effects of reasoning traces and longer outputs
test.Lipsumgeneratortest.Lipsumtest.Lipsumtest.ReasoningLipsumgenerator that usestest.Lipsumto create long reasoning tracesresolves #1696