CI: Remove fetch_ctk component hardcoding and add hash to filename#575
Merged
Conversation
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 56ffaef |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@leofang, please review |
Contributor
Author
|
@cryos, please review? |
cryos
reviewed
Apr 23, 2025
cryos
left a comment
cryos
left a comment
Collaborator
There was a problem hiding this comment.
This looks like a solid approach to me, I would say that the CI is self-testing - if this was not working then the builds and/or tests would very likely fail! Great use of defaults. Do we want to add the sanitizer to the default (not sure how much bigger it is) or should it be added to the test run that will use it?
carterbox
commented
Apr 24, 2025
leofang
approved these changes
Apr 24, 2025
cryos
approved these changes
Apr 24, 2025
Contributor
Author
|
I don't have permission to merge anything in this repo. |
Contributor
Done :-) |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes API changes to the local fetch_ctk GitHub action, so that non-admin developers can choose which CTK components are installed into the environment.
The hash of the string of the provided CTK components is now appended to the filename so that changing the components will be a cache miss.
closes #571
Checklist
- [ ] New or existing tests cover these changes.- [ ] The documentation is up to date with these changes.There are no tests for the CI, and although I have added a description to the new parameter, there are no docs for the CI?