fix(vm): scope rootfs cache by openshell version#1587
Merged
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
maxamillion
approved these changes
May 27, 2026
Collaborator
maxamillion
left a comment
maxamillion
left a comment
There was a problem hiding this comment.
+1 - I'm a fan of aggressive cache invalidation in this instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope VM bootstrap and prepared rootfs cache identities by OpenShell version so upgraded gateways build fresh guest rootfs disks instead of reusing cached disks with older embedded supervisors.
Related Issue
None.
Changes
Testing
Additional validation: mise run e2e:vm was attempted. It built a fresh v3 version-scoped rootfs cache, then failed at sandbox readiness with the existing VM supervisor callback reachability timeout: Waiting for VM supervisor with repeated NET:FAIL host.openshell.internal:.
Checklist