refactor(proto): move phase and current_policy_version into status#1565
Open
derekwaynecarr wants to merge 2 commits into
Open
refactor(proto): move phase and current_policy_version into status#1565derekwaynecarr wants to merge 2 commits into
derekwaynecarr wants to merge 2 commits into
Conversation
…atus Move phase and current_policy_version from SandboxSpec into SandboxStatus to correctly model mutable runtime state. Update all callers in the gateway server, TUI, and Python SDK to read and write these fields through SandboxStatus accessors. Signed-off-by: Derek Carr <decarr@redhat.com>
derekwaynecarr
requested review from
a team,
maxamillion and
mrunalp
as code owners
Collaborator
Author
|
/ok to test 8334767 |
johntmyers
reviewed
May 26, 2026
|
|
||
| let cpv = sandbox.current_policy_version(); | ||
| let mut status = incoming | ||
| .status |
Collaborator
There was a problem hiding this comment.
If the incoming status is None, it looks like we will set sandbox.status to that on line 979 then on line 980 set_phase() is going to create a brand-new SandboxStatus and reset cpv to 0?
Collaborator
There was a problem hiding this comment.
Looks like there's a chance the k8s driver could send a statusless update
Collaborator
Author
There was a problem hiding this comment.
yeah @mrunalp found similar, updated patch.
When a driver update arrives without a status payload (e.g. before Kubernetes populates the status subresource), preserve the stored phase, conditions, and current policy version instead of resetting them. Adds a regression test covering the edge case. Signed-off-by: Derek Carr <decarr@redhat.com>
Collaborator
Author
|
/ok to test 122942e |
mrunalp
approved these changes
May 27, 2026
TaylorMutch
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move phase and current_policy_version from SandboxSpec into SandboxStatus to correctly model mutable runtime state. Update all callers in the gateway server, TUI, and Python SDK to read and write these fields through SandboxStatus accessors.
Related Issue
Changes
Testing
mise run pre-commitpassesChecklist