Fix/cache embeddings filesystem - #722
Merged
Merged
Conversation
This commit changes the order of cache initialization in the 'cache_embeddings' decorator. Now the cache is initialized after checking if it's enabled. This prevents unnecessary initialization of the cache when it's not enabled, thus avoiding potential errors like .cache/embeddings dir creation
This commit adds two tests for the cache_embeddings decorator in the EmbeddingsCache class. The first test checks that the cache directory is created when the cache is enabled. The second test checks that the cache directory is not created when the cache is disabled. These tests help ensure that the cache_embeddings decorator behaves as expected.
drazvan
approved these changes
Sep 3, 2024
drazvan
left a comment
drazvan
left a comment
Collaborator
There was a problem hiding this comment.
Nice. Thanks for the tests 👍.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents unnecessary initialization of the cache when it is not enabled, thus avoiding
.cache/embeddingscreation.It partially resolves #655