Skip to content

Fix verbose behavior in Rails within Python script (GH-178) - #239

Merged
drazvan merged 1 commit into
NVIDIA-NeMo:developfrom
spehl-max:feature/logging_inconsistency_fix
Jan 12, 2024
Merged

Fix verbose behavior in Rails within Python script (GH-178)#239
drazvan merged 1 commit into
NVIDIA-NeMo:developfrom
spehl-max:feature/logging_inconsistency_fix

Conversation

@spehl-max

Copy link
Copy Markdown
Contributor
  • Address verbose output issue when running Rails command from a Python script.
  • When user runs rails with verbose=true the set_verbose() function is now called.
  • Response to GitHub discussion Logging #178.

@spehl-max
spehl-max force-pushed the feature/logging_inconsistency_fix branch from 5945495 to 5c5bc55 Compare December 22, 2023 03:08
- Response to GitHub discussion NVIDIA#178.

- Address verbose output issue when running Rails commands from a Python script.

Signed-off-by: Max Spehlmann <mspehlm@ncsu.edu>
@spehl-max
spehl-max force-pushed the feature/logging_inconsistency_fix branch from 5c5bc55 to 53f4f48 Compare December 22, 2023 03:27
@drazvan
drazvan self-requested a review January 11, 2024 14:02
@drazvan

drazvan commented Jan 11, 2024

Copy link
Copy Markdown
Collaborator

Thanks @spehl-max! This looks good. I'll merge in the next day or two.

@drazvan drazvan self-assigned this Jan 11, 2024

@drazvan drazvan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@drazvan
drazvan merged commit b478e43 into NVIDIA-NeMo:develop Jan 12, 2024
@drazvan drazvan added this to the v0.7.0 milestone Jan 12, 2024
christinaexyou pushed a commit to christinaexyou/NeMo-Guardrails that referenced this pull request Jun 3, 2026
… digest to bf2f5a3 (NVIDIA-NeMo#239)

Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants