Skip to content

Update codebase with appropriate coding standards - #228

Merged
drazvan merged 3 commits into
NVIDIA-NeMo:developfrom
rajveer43:doc-head
Jan 12, 2024
Merged

Update codebase with appropriate coding standards#228
drazvan merged 3 commits into
NVIDIA-NeMo:developfrom
rajveer43:doc-head

Conversation

@rajveer43

@rajveer43 rajveer43 commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

@drazvan now here the commit is verified. I will update all the docstrings soon in this branch.

@rajveer43 rajveer43 changed the title Updating docstrings. Update codebase with appropriate coding standards Dec 15, 2023
@rajveer43

Copy link
Copy Markdown
Contributor Author

@drazvan you can review this and let me know if any fix is required.

@drazvan
drazvan self-requested a review January 11, 2024 14:03
@drazvan drazvan self-assigned this Jan 11, 2024
@drazvan drazvan added this to the v0.7.0 milestone Jan 11, 2024

@drazvan drazvan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for taking the time to do this @rajveer43! 👍

@drazvan
drazvan merged commit 6758af1 into NVIDIA-NeMo:develop Jan 12, 2024
@rajveer43

Copy link
Copy Markdown
Contributor Author

Thanks again for taking the time to do this @rajveer43! 👍

there are still some left will do that in another PR!

@drazvan

drazvan commented Jan 12, 2024

Copy link
Copy Markdown
Collaborator

Yes. Soon, we should add a linter as part of the CI to check the proper formatting of all docstrings (among other things).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants