fix(streaming): handle internal errors in SSE streaming for parallel … - #1324
Merged
Conversation
…output rails Improve error handling in parallel output rails during streaming to properly surface internal errors instead of silently failing. Changes include: - Modified runtime to return internal_error status with error messages - Updated SSE streaming to emit proper error events for internal failures - Added comprehensive tests for various internal error scenarios - Ensure internal errors are properly propagated through the streaming pipeline
Pouyanpi
force-pushed
the
fix/internal-error-sse-streaming
branch
from
August 5, 2025 17:36
0947d20 to
0291570
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1324 +/- ##
===========================================
+ Coverage 70.52% 70.56% +0.03%
===========================================
Files 161 161
Lines 16267 16284 +17
===========================================
+ Hits 11473 11491 +18
+ Misses 4794 4793 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
Author
tgasser-nv
approved these changes
Aug 5, 2025
tgasser-nv
left a comment
tgasser-nv
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, CI tests are passing now
cparisien
approved these changes
Aug 5, 2025
Pouyanpi
added a commit
that referenced
this pull request
Aug 5, 2025
#1324) Improve error handling in parallel output rails during streaming to properly surface internal errors instead of silently failing. Changes include: - Modified runtime to return internal_error status with error messages - Updated SSE streaming to emit proper error events for internal failures - Added comprehensive tests for various internal error scenarios - Ensure internal errors are properly propagated through the streaming pipeline
Pouyanpi
added a commit
that referenced
this pull request
Oct 1, 2025
#1324) Improve error handling in parallel output rails during streaming to properly surface internal errors instead of silently failing. Changes include: - Modified runtime to return internal_error status with error messages - Updated SSE streaming to emit proper error events for internal failures - Added comprehensive tests for various internal error scenarios - Ensure internal errors are properly propagated through the streaming pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve error handling in parallel output rails during streaming to properly represent internal errors
Changes include: