Reduce number of teams created in the seeds#6177
Merged
thomasleese merged 3 commits intonextfrom Mar 4, 2026
Merged
Conversation
These are not useful in non-CIS2 environments since they can't be logged in to.
These were once necessary when seeding the QA environment, but the end to end tests now pick schools at random.
This should introduce a slight performance improvement when running the seeds.
e4ebf3b to
6eeb3ec
Compare
alistair-white-horne-tng
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the seeds so that we don't create CIS2 teams in non-CIS2 environments, which means the seeds run quicker for local development.
There's definitely more we could do to improve the speed of seeding the database, but this helps a lot.
Before
After