Skip to content

Inline the MultiStatementObservationHolderFactory dependency - #960

Merged
adrianclay merged 1 commit into
mainfrom
refactor-MultiStatementObservationHolderFactory
Oct 22, 2024
Merged

adrianclay merged 1 commit into
mainfrom
refactor-MultiStatementObservationHolderFactory

Conversation

@adrianclay

Copy link
Copy Markdown
Contributor

Why

This factory didn't appear to be providing any value, and is used only by the ObservationMapper, so inline it to simplify.

Type of change

Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

This factory didn't appear to be providing any value, and is used
only by the ObservationMapper, so inline it to simplify.
@github-actions

Copy link
Copy Markdown

Looks good. All 2 mutations in this change were killed.

class surviving killed
💯uk.nhs.adaptors.gp2gp.ehr.mapper.diagnosticreport.ObservationMapper 0 2

See https://pitest.org

@adrianclay
adrianclay enabled auto-merge (squash) October 22, 2024 12:52
@adrianclay
adrianclay merged commit 9f1a3a8 into main Oct 22, 2024
@adrianclay
adrianclay deleted the refactor-MultiStatementObservationHolderFactory branch October 22, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants