Skip to content

NIAD-3137: Refactor to use IsEqualToIgnoringWhitespace#884

Merged
MartinWheelerMT merged 1 commit intomainfrom
niad-3137-refactor
Sep 17, 2024
Merged

NIAD-3137: Refactor to use IsEqualToIgnoringWhitespace#884
MartinWheelerMT merged 1 commit intomainfrom
niad-3137-refactor

Conversation

@MartinWheelerMT
Copy link
Copy Markdown
Collaborator

What

A quick refactor to use IsEqualToIgnoringWhitespace rather than helper method doing the same thing.

Why

Code clarity and to remove unnecessary helper function

Type of change

Please delete options that are not relevant.

  • Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions
Copy link
Copy Markdown

Looks good. No mutations were possible for these changes.
See https://pitest.org

@MartinWheelerMT MartinWheelerMT marked this pull request as draft September 17, 2024 16:13
@MartinWheelerMT MartinWheelerMT marked this pull request as ready for review September 17, 2024 16:16
Base automatically changed from niad-3137-add-test-for-suppressed-medication-request to main September 17, 2024 16:22
@MartinWheelerMT MartinWheelerMT enabled auto-merge (squash) September 17, 2024 16:46
@github-actions
Copy link
Copy Markdown

Looks good. No mutations were possible for these changes.
See https://pitest.org

Change term from suppressed to describing actual behaviour in unit tests and test files
@MartinWheelerMT MartinWheelerMT merged commit c5d0e05 into main Sep 17, 2024
@MartinWheelerMT MartinWheelerMT deleted the niad-3137-refactor branch September 17, 2024 16:54
@github-actions
Copy link
Copy Markdown

Looks good. No mutations were possible for these changes.
See https://pitest.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants