Skip to content

Replace logback-classic dependency with spring-boot-starter-logging#696

Merged
adrianclay merged 1 commit intomainfrom
remove-logback
Apr 10, 2024
Merged

Replace logback-classic dependency with spring-boot-starter-logging#696
adrianclay merged 1 commit intomainfrom
remove-logback

Conversation

@adrianclay
Copy link
Copy Markdown
Contributor

Why

This will reduce the dependencies we have to keep up to date, as Spring can maintain that.

We can instead focus on keeping Spring up to date and trust that they are patching logback-classic as and when required.

+--- org.springframework.boot:spring-boot-starter-logging:3.2.4
|    +--- ch.qos.logback:logback-classic:1.4.14
|    |    +--- ch.qos.logback:logback-core:1.4.14
|    |    \--- org.slf4j:slf4j-api:2.0.7 -> 2.0.12

Type of change

  • Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

This will reduce the dependencies we have to keep up to date, as
Spring can maintain that.

We can instead focus on keeping Spring up to date and trust that
they are patching logback-classic as and when required.
@adrianclay adrianclay enabled auto-merge (squash) April 10, 2024 11:14
@adrianclay adrianclay merged commit d0e55c9 into main Apr 10, 2024
@adrianclay adrianclay deleted the remove-logback branch April 10, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants