Skip to content

validate storage service configuration - #1247

Merged
Jonopono123 merged 5 commits into
mainfrom
NIAD-950/storage-service
Feb 26, 2026
Merged

validate storage service configuration#1247
Jonopono123 merged 5 commits into
mainfrom
NIAD-950/storage-service

Conversation

@Jonopono123

Copy link
Copy Markdown
Contributor

What

Validation for the storage service configuration

Why

When invalid config is provided (or config is missing) the service spits out a verbose and convoluted message. This should be simplified to instead log a very direct error stating which config is incorrect.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@Jonopono123
Jonopono123 requested a review from a team as a code owner February 26, 2026 14:28
@github-actions

github-actions Bot commented Feb 26, 2026

Copy link
Copy Markdown

Images built and published to ECR using a Build Id of PR-965-ac6e652

@github-actions

Copy link
Copy Markdown
  • Surviving mutants in this change: 20
  • Killed mutants in this change: 0
class surviving killed
🧟uk.nhs.adaptors.pss.translator.validation.StorageServiceConfigurationValidator 18 0
🧟uk.nhs.adaptors.pss.translator.validation.StorageServiceConfigurationValidator$ValidationRule 2 0

See https://pitest.org

@Jonopono123
Jonopono123 merged commit d98f033 into main Feb 26, 2026
30 of 31 checks passed
@Jonopono123
Jonopono123 deleted the NIAD-950/storage-service branch February 26, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants