Skip to content

validate Mhs Queue properties - #1246

Merged
Jonopono123 merged 3 commits into
mainfrom
NIAD-950/mhs-queue
Feb 25, 2026
Merged

validate Mhs Queue properties#1246
Jonopono123 merged 3 commits into
mainfrom
NIAD-950/mhs-queue

Conversation

@Jonopono123

Copy link
Copy Markdown
Contributor

What

Added validation around MHS Queue Config Variables

Why

If these are not provided, typically the terminal spits out a verbose and potentially convoluted message, which would be much more useful if it simply pointed at the missing variables.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@Jonopono123
Jonopono123 requested a review from a team as a code owner February 25, 2026 10:11
@github-actions

Copy link
Copy Markdown
  • Surviving mutants in this change: 10
  • Killed mutants in this change: 0
class surviving killed
🧟uk.nhs.adaptors.pss.translator.validation.MhsQueuePropertyValidator 10 0

See https://pitest.org

@github-actions

Copy link
Copy Markdown

Images built and published to ECR using a Build Id of PR-960-ce58f14

@Jonopono123
Jonopono123 merged commit d3588b6 into main Feb 25, 2026
19 checks passed
@Jonopono123
Jonopono123 deleted the NIAD-950/mhs-queue branch February 25, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants