Skip to content

NIAD-3412: test refactoring - #1237

Merged
ORybak5 merged 2 commits into
mainfrom
NIAD-3412-refactoring
Jan 26, 2026
Merged

NIAD-3412: test refactoring#1237
ORybak5 merged 2 commits into
mainfrom
NIAD-3412-refactoring

Conversation

@ORybak5

@ORybak5 ORybak5 commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

What

Similar tests with boilerplate code were refactored into parametric ones

Why

Parametric tests are more concise if there is a lot of similar boilerplate code

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users
  • A corresponding change has been made to the Mapping Documentation repository

@github-actions

Copy link
Copy Markdown

Looks good. No mutations were possible for these changes.
See https://pitest.org

@github-actions

Copy link
Copy Markdown

Images built and published to ECR using a Build Id of PR-939-f225db8

@ORybak5
ORybak5 marked this pull request as ready for review January 23, 2026 11:02
@ORybak5
ORybak5 requested a review from a team as a code owner January 23, 2026 11:02
@ORybak5
ORybak5 merged commit 5157569 into main Jan 26, 2026
30 of 31 checks passed
@ORybak5
ORybak5 deleted the NIAD-3412-refactoring branch January 26, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants