Skip to content

Niad-3407: Remove usages of Mockito.lenient() in test suite - #1234

Merged
Jonopono123 merged 26 commits into
mainfrom
NIAD-3407-remove-lenient
Jan 8, 2026
Merged

Niad-3407: Remove usages of Mockito.lenient() in test suite#1234
Jonopono123 merged 26 commits into
mainfrom
NIAD-3407-remove-lenient

Conversation

@Jonopono123

@Jonopono123 Jonopono123 commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

What

There are numerous usages of Mockito.lenient() in the codebase. These need to be removed.

Why

Using Mockito.lenient() in this way covers up any dependency related issues in our tests, reducing their reliability.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Jonopono123
Jonopono123 requested a review from a team as a code owner January 7, 2026 11:15
@Jonopono123 Jonopono123 changed the title Niad 3407 remove lenient Niad 3407 remove usages of Mockito.lenient() in test suite Jan 7, 2026
@Jonopono123 Jonopono123 changed the title Niad 3407 remove usages of Mockito.lenient() in test suite Niad-3407: Remove usages of Mockito.lenient() in test suite Jan 7, 2026
@github-actions

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown

Looks good. No mutations were possible for these changes.
See https://pitest.org

@github-actions

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown

Images built and published to ECR using a Build Id of PR-910-e74e91b

@Jonopono123
Jonopono123 merged commit 1e0df6e into main Jan 8, 2026
19 checks passed
@Jonopono123
Jonopono123 deleted the NIAD-3407-remove-lenient branch January 8, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants