VED-000 README documentation updates and removed obsolete dev tools#1181
Merged
dlzhry2nhs merged 2 commits intomasterfrom Feb 3, 2026
Merged
VED-000 README documentation updates and removed obsolete dev tools#1181dlzhry2nhs merged 2 commits intomasterfrom
dlzhry2nhs merged 2 commits intomasterfrom
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-000 |
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
edhall-nhs
reviewed
Feb 3, 2026
| | `delta_backend` | **Imms Sync** – Lambda function that reacts to events in the Immunisation Event Data Store (IEDS). | | ||
| | `filenameprocessor` | **Imms Batch** – Validates and processes new batch file events. | | ||
| | `id_sync` | **Imms Cross-cutting** – Handles [MNS](https://digital.nhs.uk/developer/api-catalogue/multicast-notification-service) NHS Number Change events and applies updates to affected records. | | ||
| | `mesh_processor` | **Imms Batch** – Triggered when new files our received via MESH. Moves them into the Imms Batch processing system. | |
Contributor
There was a problem hiding this comment.
Should this be 'are' not 'our'?
Contributor
Author
There was a problem hiding this comment.
Should all be done now. Please re-check.
edhall-nhs
reviewed
Feb 3, 2026
| | **`converter.py`** | 🧠 The main brain — applies the schema, runs conversions, handles errors. | | ||
| | **`converter.py`** | The main brain — applies the schema, runs conversions, handles errors. | | ||
| | **`conversion_layout.py`** | A plain Python list that defines which fields you want, and how they should be formatted (e.g. date format, renaming rules). | | ||
| | **`delta.py`** | Holds the function called by AWS Lambda | |
Contributor
There was a problem hiding this comment.
Hate to be the punctuation police but this is missing a full stop 🙈
edhall-nhs
reviewed
Feb 3, 2026
edhall-nhs
reviewed
Feb 3, 2026
| the Apigee proxy and sandbox. The new way to manage and deploy said resources is [Proxygen](https://digital.nhs.uk/developer/api-catalogue/proxy-generator). | ||
|
|
||
| In future a migration plan will be provided by the API Management team so we can move to the new process and use purely | ||
| GitHub Actions for our entire pipeline |
edhall-nhs
previously approved these changes
Feb 3, 2026
Contributor
edhall-nhs
left a comment
edhall-nhs
left a comment
There was a problem hiding this comment.
Looks great. A much clearer read. Only spotted a few superficial things
JamesW1-NHS
reviewed
Feb 3, 2026
| Event Data Store. It will receive up to 100 records per batch. Each record will have been processed and formatted as a | ||
| FHIR Immunization by the ECS Record Processor in the prior batch step. | ||
|
|
||
| The Record Forwarded Lambda will then execute the requested operation (Create, Update or Delete) on the given record. |
Contributor
There was a problem hiding this comment.
typo: 'Record Forwarder'
Contributor
Author
There was a problem hiding this comment.
Should all be resolved now. Please re-check.
| | `delta_backend` | **Imms Sync** – Lambda function that reacts to events in the Immunisation Event Data Store (IEDS). | | ||
| | `filenameprocessor` | **Imms Batch** – Validates and processes new batch file events. | | ||
| | `id_sync` | **Imms Cross-cutting** – Handles [MNS](https://digital.nhs.uk/developer/api-catalogue/multicast-notification-service) NHS Number Change events and applies updates to affected records. | | ||
| | `mesh_processor` | **Imms Batch** – Triggered when new files our received via MESH. Moves them into the Imms Batch processing system. | |
dlzhry2nhs
force-pushed
the
feature/VED-000-improve-documentation
branch
from
aa20b17 to
5e26017
Compare
edhall-nhs
approved these changes
Feb 3, 2026
|
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.