Skip to content

VED-298: Fix Sandbox#1069

Merged
JamesW1-NHS merged 7 commits intomasterfrom
VED-298-OAS
Dec 16, 2025
Merged

VED-298: Fix Sandbox#1069
JamesW1-NHS merged 7 commits intomasterfrom
VED-298-OAS

Conversation

@JamesW1-NHS
Copy link
Copy Markdown
Contributor

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Copy Markdown
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-298

Comment thread README.specification.md Outdated
dlzhry2nhs
dlzhry2nhs previously approved these changes Dec 16, 2025
Copy link
Copy Markdown
Contributor

@dlzhry2nhs dlzhry2nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment regarding the README. Other than that looks great.

I assume you tested each endpoint locally? I have not had time to check out and play with the sandbox since yesterday. I assume that's the case, and if so, once merged we can just do a quick smoketest of each endpoint from the API page itself and close this one off.

@JamesW1-NHS
Copy link
Copy Markdown
Contributor Author

Minor comment regarding the README. Other than that looks great.

I assume you tested each endpoint locally? I have not had time to check out and play with the sandbox since yesterday. I assume that's the case, and if so, once merged we can just do a quick smoketest of each endpoint from the API page itself and close this one off.

Yes indeed. All tested with the curl -i option; no violations reported.

@sonarqubecloud
Copy link
Copy Markdown

@JamesW1-NHS JamesW1-NHS temporarily deployed to internal-dev-sandbox December 16, 2025 17:31 — with GitHub Actions Inactive
@JamesW1-NHS JamesW1-NHS temporarily deployed to internal-dev-sandbox December 16, 2025 17:35 — with GitHub Actions Inactive
@JamesW1-NHS JamesW1-NHS merged commit 6ce912d into master Dec 16, 2025
19 of 20 checks passed
@JamesW1-NHS JamesW1-NHS deleted the VED-298-OAS branch December 16, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants