VED-956 Add information to logs for ITOC#1051
Merged
dlzhry2nhs merged 1 commit intoVED-956-Audit-Table-Updatefrom Dec 8, 2025
Merged
VED-956 Add information to logs for ITOC#1051dlzhry2nhs merged 1 commit intoVED-956-Audit-Table-Updatefrom
dlzhry2nhs merged 1 commit intoVED-956-Audit-Table-Updatefrom
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-956 |
dlzhry2nhs
commented
Dec 8, 2025
| "function_name": f"{PREFIX}_{func.__name__}", | ||
| "date_time": str(datetime.now()), | ||
| } | ||
| start_time = time.time() |
Contributor
Author
There was a problem hiding this comment.
You can check on master but I have returned this to how it used to be.
We use this value in generate_and_send_logs to calculate the time taken for the wrapped function to complete. Setting this value to some time during the execution of the function rather than actually at the beginning would have broken this functionality.
|
JamesW1-NHS
approved these changes
Dec 8, 2025
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.