Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-000 |
edhall-nhs
previously approved these changes
Nov 27, 2025
JamesW1-NHS
previously approved these changes
Nov 27, 2025
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Akol125
had a problem deploying
to
internal-dev-sandbox
GitHub Actions
Failure
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
krupasindhubaral
approved these changes
Nov 27, 2025
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
|
Akol125
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
JamesW1-NHS
added a commit
that referenced
this pull request
Dec 2, 2025
* Refactor extended attributes * check extended attributes and move file * refactor extended attribute journeys * rolling back test * add test for file validation * refactor filenameprocessor file path into two * add test for move outside bucket * add upserts for EA files * ruff * fix upsert * test for no condition_expression * ACCOUNT_ID in tf * pathname * pathname II * cherry-pick #1013 * resolve e2e batch * unit tests * fix to e2e_batch * cleanup trace * change buckeowner and destination bucket name * duplicate batch fix * duplicate batch test fix * duplicate batch fix * change bucket name to dps destination * revert error message * bugfix - delete_file() * bugfix - delete_file() II * comment * resolve comments * fix shared utils * remove prefix * remove file validation patching * remove file validation patching * ruff * EXTENDED_ATTRIBUTES_VACC_TYPE * EXPECTED_BUCKET_OWNER_ACCOUNT * formatting * test_unexpected_bucket_name_with_extended_attributes_file * test_lambda_handler_extended_attributes_failure * remove copy check, some comments * remove copy check, some comments II * improved test_unexpected_bucket_name_and_filename_validation_fails * expiry_timestamp: int * ruff * test_lambda_handler_extended_attributes_failure --------- Co-authored-by: Akol125 <akinola.olutola1@nhs.net>
dlzhry2nhs
pushed a commit
that referenced
this pull request
Jan 19, 2026
* Refactor extended attributes * check extended attributes and move file * refactor extended attribute journeys * rolling back test * add test for file validation * refactor filenameprocessor file path into two * add test for move outside bucket * add upserts for EA files * ruff * fix upsert * test for no condition_expression * ACCOUNT_ID in tf * pathname * pathname II * cherry-pick #1013 * resolve e2e batch * unit tests * fix to e2e_batch * cleanup trace * change buckeowner and destination bucket name * duplicate batch fix * duplicate batch test fix * duplicate batch fix * change bucket name to dps destination * revert error message * bugfix - delete_file() * bugfix - delete_file() II * comment * resolve comments * fix shared utils * remove prefix * remove file validation patching * remove file validation patching * ruff * EXTENDED_ATTRIBUTES_VACC_TYPE * EXPECTED_BUCKET_OWNER_ACCOUNT * formatting * test_unexpected_bucket_name_with_extended_attributes_file * test_lambda_handler_extended_attributes_failure * remove copy check, some comments * remove copy check, some comments II * improved test_unexpected_bucket_name_and_filename_validation_fails * expiry_timestamp: int * ruff * test_lambda_handler_extended_attributes_failure --------- Co-authored-by: Akol125 <akinola.olutola1@nhs.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.