Breaking: [AEA-6593] - use new exports from cdk stacks#711
Merged
anthony-nhs merged 6 commits intomainfrom Apr 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates cdkConstructs cross-stack import value names (and the corresponding unit tests) to align with the new export naming scheme used by shared “account resources” / “secrets” stacks.
Changes:
- Update
ACCOUNT_RESOURCESandLAMBDA_RESOURCESFn.importValue(...)strings to the new export names. - Update construct snapshot/assertion tests to expect the new
Fn::ImportValuestrings for KMS keys, IAM policy ARNs, and Splunk subscription filter resources.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cdkConstructs/src/constants.ts | Switches centralized cross-stack import names to the new export naming scheme. |
| packages/cdkConstructs/tests/constructs/typescriptFunctionConstruct.test.ts | Updates expected Fn::ImportValue strings for Lambda log group encryption, Splunk forwarding, and managed policies. |
| packages/cdkConstructs/tests/constructs/pythonLambdaFunctionConstruct.test.ts | Updates expected Fn::ImportValue strings for Python Lambda log group encryption, Splunk forwarding, and managed policies. |
| packages/cdkConstructs/tests/constructs/stateMachineConstruct.test.ts | Updates expected Fn::ImportValue strings for Step Functions log group encryption and Splunk role import. |
| packages/cdkConstructs/tests/constructs/RestApiGateway.test.ts | Updates expected Fn::ImportValue strings for API Gateway/truststore deployment log group encryption and Splunk forwarding. |
|
MatthewPopat-NHS
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Details