Skip to content

Breaking: [AEA-6593] - use new exports from cdk stacks#711

Merged
anthony-nhs merged 6 commits intomainfrom
new_imports
Apr 29, 2026
Merged

Breaking: [AEA-6593] - use new exports from cdk stacks#711
anthony-nhs merged 6 commits intomainfrom
new_imports

Conversation

@anthony-nhs
Copy link
Copy Markdown
Contributor

@anthony-nhs anthony-nhs commented Apr 27, 2026

Summary

  • Routine Change

Details

  • use new exports from cdk stacks
  • move exports into correct exported variables

Copilot AI review requested due to automatic review settings April 27, 2026 13:52
@anthony-nhs anthony-nhs changed the title Chore: [AEA-0000] - move to new import names Chore: [AEA-6593] - move to new import names Apr 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates cdkConstructs cross-stack import value names (and the corresponding unit tests) to align with the new export naming scheme used by shared “account resources” / “secrets” stacks.

Changes:

  • Update ACCOUNT_RESOURCES and LAMBDA_RESOURCES Fn.importValue(...) strings to the new export names.
  • Update construct snapshot/assertion tests to expect the new Fn::ImportValue strings for KMS keys, IAM policy ARNs, and Splunk subscription filter resources.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/cdkConstructs/src/constants.ts Switches centralized cross-stack import names to the new export naming scheme.
packages/cdkConstructs/tests/constructs/typescriptFunctionConstruct.test.ts Updates expected Fn::ImportValue strings for Lambda log group encryption, Splunk forwarding, and managed policies.
packages/cdkConstructs/tests/constructs/pythonLambdaFunctionConstruct.test.ts Updates expected Fn::ImportValue strings for Python Lambda log group encryption, Splunk forwarding, and managed policies.
packages/cdkConstructs/tests/constructs/stateMachineConstruct.test.ts Updates expected Fn::ImportValue strings for Step Functions log group encryption and Splunk role import.
packages/cdkConstructs/tests/constructs/RestApiGateway.test.ts Updates expected Fn::ImportValue strings for API Gateway/truststore deployment log group encryption and Splunk forwarding.

@anthony-nhs anthony-nhs enabled auto-merge (squash) April 28, 2026 13:39
@anthony-nhs anthony-nhs changed the title Chore: [AEA-6593] - move to new import names Breaking: [AEA-6593] - use new exports from cdk stacks Apr 29, 2026
@sonarqubecloud
Copy link
Copy Markdown

@anthony-nhs anthony-nhs merged commit 8743107 into main Apr 29, 2026
11 checks passed
@anthony-nhs anthony-nhs deleted the new_imports branch April 29, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants