Skip to content

[DTOSS-10700] Allows secrets to be stored within the container app and container app job#224

Merged
mrlockstar merged 2 commits intomainfrom
feat/DTOSS-10700-Use-a-docker-image-for-the-postgres-database-for-the-review-apps
Sep 2, 2025
Merged

[DTOSS-10700] Allows secrets to be stored within the container app and container app job#224
mrlockstar merged 2 commits intomainfrom
feat/DTOSS-10700-Use-a-docker-image-for-the-postgres-database-for-the-review-apps

Conversation

@mrlockstar
Copy link
Copy Markdown
Contributor

@mrlockstar mrlockstar commented Aug 29, 2025

Description

Small changes to how the postgres database is deployed for review apps. Essentially you can now allow a postgres database be deployed in a container app. If you do this you also need to modify the ingress to allow TCP communication so that other Azure services can communicate with it.

Here you can see that it has been successfully deployed: -

https://dev.azure.com/nhse-dtos/dtos-manage-breast-screening/_build/results?buildId=26435&view=logs&j=4a575bb6-72e3-5024-4059-681dfff5b130

Also allows secrets to be stored within the container app and container app job.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@mrlockstar mrlockstar force-pushed the feat/DTOSS-10700-Use-a-docker-image-for-the-postgres-database-for-the-review-apps branch from bf9d621 to ad35f7f Compare August 29, 2025 13:52
@mrlockstar mrlockstar requested a review from saliceti August 29, 2025 13:52
MacMur85
MacMur85 previously approved these changes Sep 1, 2025
Copy link
Copy Markdown
Contributor

@MacMur85 MacMur85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mrlockstar mrlockstar force-pushed the feat/DTOSS-10700-Use-a-docker-image-for-the-postgres-database-for-the-review-apps branch 2 times, most recently from bb3dfc4 to 46f76f3 Compare September 2, 2025 12:03
@mrlockstar mrlockstar force-pushed the feat/DTOSS-10700-Use-a-docker-image-for-the-postgres-database-for-the-review-apps branch from 46f76f3 to bbec29d Compare September 2, 2025 12:35
@mrlockstar mrlockstar force-pushed the feat/DTOSS-10700-Use-a-docker-image-for-the-postgres-database-for-the-review-apps branch from bbec29d to c252bfc Compare September 2, 2025 12:40
@mrlockstar mrlockstar added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit d04f2c6 Sep 2, 2025
13 checks passed
@mrlockstar mrlockstar deleted the feat/DTOSS-10700-Use-a-docker-image-for-the-postgres-database-for-the-review-apps branch September 2, 2025 13:09
@saliceti saliceti changed the title Feat/dtoss 10700 use a docker image for the postgres database for the review apps [DTOSS-10700] Allows secrets to be stored within the container app and container app job Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants