Conversation
APageNHS
requested review from
KevinMayfield,
declankieran,
omarisgreat and
ryma2fhir
Contributor
|
Agree, If the flag was true it would skip the validation of bundles within MessageDefinitionProvider in the validition-service repo. Removing this flag would still validate any UKCore resources by using the UKCore CapabilityStatement, so this code is redundant. |
ryma2fhir
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per the Grail validation chat, UK core repo was validating differently to repos with a uk core dependcy, and thus not giving reliable results
Removed the boolean flag for is UK Core - still has a check on whether its the repo or dependency - i'm thinking of reusing this check for meta.profile