removed redundant code from masterfhirvalidation.yml, including python and poetry

[ryma2fhir]

This has been tested on a fork in my repo and is still working correctly.

[declankieran]

I'd be surprised if this step

      - name: Cache node modules
        uses: actions/cache@v3
        with:
          path: ~/.npm
          key: ${{ runner.os }}-build-cache-npm-packages-${{ hashFiles('**/package-lock.json') }}

is providing any noticeable speed-up in the execution of the workflow. I'd suggest trying without and removing it if there is no significant difference.

[ryma2fhir]

removed cache, jkd/node/npm install as not needed. makefile deleted as not needed. Saved approx 1 min per action, but the biggest times are the build and run fhir validator steps.

[declankieran]

Actually one of the jobs failed and it seems like its the Makefile being removed made it fail

In testingbranch.yml

Is this just another copy of the validation script?

[ryma2fhir]

Actually one of the jobs failed and it seems like its the Makefile being removed made it fail

In testingbranch.yml

Is this just another copy of the validation script?

Very similar. The last few lines of code are installing, building and testing the IOPS-FHIR-Validation-Service repo and not this one. I have no idea what that is actually testing, but that's for another day. I've replaced the make line for this repo to get it running again. Working as expected (error on FHIR asset not passing test).

[declankieran]

I think its now possible just catching a change in the display of some of the codes, not related to the actual running of the script, e.g. http://snomed.info/sct#322236009 has a preferred synonym of "Paracetamol 500 mg oral tablet", not "Paracetamol 500mg tablets" on the current version showing on the snomed ct browser, haven't checked which version you are referencing. Probably worth fixing those just to get a clean run of the validation script to be sure there are no other issues.

reverted code back as make was pointing to another repo