(#5183) Migrates biography body to ncids full wysiwyg - #5334
Open
dlescarbeau wants to merge 3 commits into
Open
Conversation
dlescarbeau
force-pushed
the
ticket/5183-migrate-biography-body-ncids
branch
5 times, most recently
from
August 12, 2026 17:15
38d9d87 to
365b961
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates Biography pages to use the NCIDS Full WYSIWYG for the body field and aligns the biography page rendering/asset loading with the “migrated inner page” approach used elsewhere in ncids_trans.
Changes:
- Switch Biography body text format/config (and sample YAML content) from
full_htmltoncids_full_html. - Update Biography theming/layout to render the body directly and conditionally render the legacy press-info region, adding new block/region templates + styling for the press contact UI.
- Update
ncids_transfront-end biography entrypoint to remove legacy styles and add NCIDS body-related JS (definitions + body link analytics).
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/templates/layout/regions/region--bio_press_info.html.twig | Adds a wrapper for the bio press-info region so it can be styled with the new component class. |
| docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/templates/content/biography/node--cgov-biography--full.html.twig | Adjusts Biography full node layout and renders body/press-info region inline. |
| docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/templates/block/ncids/block--bio-press-info.html.twig | Adds a block override for the bio press-info block output. |
| docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/ncids_trans.theme | Treats biographies as “migrated inner pages” for page template suggestions. |
| docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/ncids_trans.libraries.yml | Updates Biography library dependency to ncids-inner-minimal. |
| docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/front-end/src/lib/components/cgdp-press-contact/index.scss | Introduces the new press-contact component styling. |
| docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/front-end/src/entrypoints/biography/biography.ts | Removes legacy stylesheet import; adds definition + body link analytics initialization. |
| docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/front-end/src/entrypoints/biography/biography.scss | Forwards new press-contact + NCIDS full HTML editor + definition styles. |
| docroot/profiles/custom/cgov_site/themes/custom/ncids_trans/front-end/src/entrypoints/biography/biography-legacy.scss | Removes legacy SCSS entrypoint. |
| docroot/profiles/custom/cgov_site/modules/custom/cgov_yaml_content/content/*.content.yml | Updates sample content bodies to ncids_full_html (and toggles bio press-info on one test page). |
| docroot/profiles/custom/cgov_site/modules/custom/cgov_biography/config/install/field.field.node.cgov_biography.body.yml | Restricts Biography body allowed formats to ncids_full_html. |
| docroot/profiles/custom/cgov_site/modules/custom/cgov_biography/cgov_biography.install | Updates press-info block setup for ncids_trans and adds an update hook to change stored body format. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+51
to
+55
| {% if content.field_phone_number|field_value or content.field_email_address|field_value %} | ||
| <a href="tel:{{- content.field_phone_number|field_value -}}" rel="nofollow">{{ content.field_phone_number }}</a> | ||
| {{ (content.field_phone_number|field_value and content.field_email_address|field_value)? '<span class="contact-divider">|</span>': '' }} | ||
| {{ content.field_email_address }} | ||
| {% endif %} |
dlescarbeau
force-pushed
the
ticket/5183-migrate-biography-body-ncids
branch
2 times, most recently
from
August 12, 2026 18:57
7ac50f8 to
5ede06a
Compare
dlescarbeau
force-pushed
the
ticket/5183-migrate-biography-body-ncids
branch
from
August 13, 2026 15:09
5ede06a to
c8d6ebf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5183