Clean Tool: Morphs in new Diffeomorphic versions are not cleaned

[Mustard2]

[cl3m3c7]

can we just use Diffeo's operator bpy.ops.daz.remove_standard_morphs instead of the custom one (remove_props_from_group("Daz...")) plus the bonus of all other categories that are not included like Visems, FacsExpressions ... ?

we can just reuse it since the plugin is necessary anyways!

EDIT: and the reason is to not maintain the method every time the plugin (Daz Importer) changes, it will be taken care of automatically ;)

[cl3m3c7]

for reference: https://bitbucket.org/Diffeomorphic/import_daz/wiki/Scripting/DAZ%20Importer%20Operators

bpy.ops.daz.remove_standard_morphs

[Mustard2]

Unfortunately due to how the Extensions rules are made, we cannot use operators that require the presence of another addon.

One possible solution would be to copy the implementation, and check if we need to use the old or the new one.

[Mustard2]

Actually we can't because we cannot access the internal data set by Diffeomorphic from another addon. GG :D

Probably we'd have to loop over all possible drivers in the scene and delete them manually?
Or just link to the Daz documentation for removing the custom properties?

Not sure what the best solution might be.

[cl3m3c7]

bpy.ops.daz.remove_standard_morphs

it is working,

bpy.ops.daz.remove_standard_morphs(
	useUnits=True,
	useExpressions=True,
	useBody=True,
	useFacs=self.remove_morphs_facs,
	useFacsdetails=self.remove_morphs_facs,
	useFacsexpr=self.remove_morphs_facs,
	useJcms=self.remove_morphs_jcms,
	useDeleteShapekeys=self.remove_morphs_shapekeys,
)

but it is just half the solution, trying to figure out how to deal with DazCustom and DazMorphCats.

[cl3m3c7]

or we can defer that to the import daz addon and call it a day 😅

[cl3m3c7]

or we can defer that to the import daz addon and call it a day 😅

since we will just reuse the functionality without any additional logic, why bother use it at all. I think it is best to let the add-on (daz import) manage the morphs.

[Mustard2]

bpy.ops.daz.remove_standard_morphs

it is working,

bpy.ops.daz.remove_standard_morphs(
useUnits=True,
useExpressions=True,
useBody=True,
useFacs=self.remove_morphs_facs,
useFacsdetails=self.remove_morphs_facs,
useFacsexpr=self.remove_morphs_facs,
useJcms=self.remove_morphs_jcms,
useDeleteShapekeys=self.remove_morphs_shapekeys,
)

but it is just half the solution, trying to figure out how to deal with DazCustom and DazMorphCats.

Yes, I suppose it does. The issue is that you would have to check if the addon is available to use the operator, and at the last code review by Blender, that was highly discouraged.
One idea might be to just copy that operator code in MustardUI, but I'm not sure if it's possible to use because we could not access the data probably.

I also agree that it might be good to just remove this and send people to Diffeomorphic. But it was nice to have a single operator/panel that would do everything :D

[cl3m3c7]

But it was nice to have a single operator/panel that would do everything :D

💯 but the thing is most Daz to blender users have diffeo installed and managing morphs is better done in it, and like I mentioned, when they change the api, no need to do anything 😉

[Mustard2]

But again, it's not possible to add references to external addons if I want to keep it as an extension on extensions.blender.org. They're strict about this. You can check what happened with the pre-review version, I had to remove all external addons checks/functions as requested by the reviewer to get the addon accepted. :(

[cl3m3c7]

what I meant, is to state that in docs or as a suggestion to use diffeo to manage morphs not use it or check for it.

[Mustard2]

Ah sorry, misunderstanding on my side then. That might be the best solution yes!