Skip to content

ethiopic - #562

Merged
Mottie merged 4 commits into
Mottie:masterfrom
PietroLiuzzo:master
May 11, 2017
Merged

ethiopic#562
Mottie merged 4 commits into
Mottie:masterfrom
PietroLiuzzo:master

Conversation

@PietroLiuzzo

@PietroLiuzzo PietroLiuzzo commented May 11, 2017

Copy link
Copy Markdown
Contributor

ethiopic keyboard layout and language file with combos to support amahric and geez. Translation in language file by Dr. Solomon Gebreyes Beyene. It also contains diacritics for transliteration.

Comment thread languages/amh.js
// Keyboard Language
// please update this section to match this language and email me with corrections!
// "all" is used here for example purposes, by convention it should be the ISO 639-1 code for the specified language
// ***********************

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please give yourself and Dr. Beyene credit in the comment section!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, I hope is ok!

Comment thread languages/amh.js Outdated
// please update this section to match this language and email me with corrections!
// "all" is used here for example purposes, by convention it should be the ISO 639-1 code for the specified language
// ***********************
jQuery.keyboard.language.all = {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the "all" with the language abbreviation for Ethiopic... I tried to find one using ISO-639-3 language codes, but it isn't listed.

@Mottie

Mottie commented May 11, 2017

Copy link
Copy Markdown
Owner

Please fix the all references in the file (2x) with amh and I think we'll be good to go!

  • in the comments - remove the line starting with // "all" is used here...
  • jQuery.keyboard.language.amh = {

although this works also for gez which is our main purpose.
@PietroLiuzzo

Copy link
Copy Markdown
Contributor Author

I failed to find in amh.js the second all.

@Mottie

Mottie commented May 11, 2017

Copy link
Copy Markdown
Owner

Hehe sorry, the first was the comment line I asked you to remove.

It looks good, thank you again!

@Mottie
Mottie merged commit de68263 into Mottie:master May 11, 2017
@PietroLiuzzo

Copy link
Copy Markdown
Contributor Author

thanks to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants