docs: fix Notification hook matcher example - #2335
Conversation
|
One remaining doc mismatch: this patch fixes the example and matcher table, but the use-case list above still says desktop notifications can "Send alerts when human approval is needed" / "在需要人工审批时发送通知". Since approval requests are not |
|
Follow-up pushed in 5aec6ff. Updated the top use-case list in both English and Chinese docs to use background task notifications instead of human approval notifications. Validation on Windows:
Note: the full tests/hooks/test_integration.py file still has existing Windows shell/python3 failures unrelated to this doc-only change. |
|
Closing this during backlog cleanup. There has been no human maintainer signal, the repository is no longer an active target for new work, and keeping many stale small PRs open makes the queue noisy. Happy to reopen or refresh it if maintainers want this specific change. |
Summary
permission_promptNotification hook example with real background-task notification typesFixes #2330
To verify
uv run --package kimi-cli --group dev pytest tests/hooks/test_integration.py::test_config_roundtrip_toml tests/hooks/test_integration.py::test_notification_hook -q -p no:cacheprovideruv run --package kimi-cli --group dev ruff check tests/hooks/test_integration.pygit diff --checkNote: running the whole
tests/hooks/test_integration.pyfile on Windows still hits existing shell assumptions aroundbash/python3; the two tests touched by this patch pass.