Fix incorrect documentation for EFI_RNG_GET_RNG - #4048
Open
Josh Triplett (joshtriplett) wants to merge 1 commit into
Open
Fix incorrect documentation for EFI_RNG_GET_RNG#4048Josh Triplett (joshtriplett) wants to merge 1 commit into
EFI_RNG_GET_RNG#4048Josh Triplett (joshtriplett) wants to merge 1 commit into
Conversation
`EFI_RNG_GET_RNG` is incorrectly described as returning an allocated buffer that the caller must free. It fills in a user-provided buffer. Update the documentation and error codes, based on <https://uefi.org/specs/UEFI/2.11/37_Secure_Technologies.html#efi-rng-protocol-getrng>.
Contributor
|
Josh Triplett (@joshtriplett) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Contributor
|
Josh Triplett (@joshtriplett) : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit a95bd91: ✅ Validation status: passed
For more details, please refer to the build report. |
|
我已经收到邮件~
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EFI_RNG_GET_RNGis incorrectly described as returning an allocatedbuffer that the caller must free. It fills in a user-provided buffer.
Update the documentation and error codes, based on
https://uefi.org/specs/UEFI/2.11/37_Secure_Technologies.html#efi-rng-protocol-getrng.
EFI_RNG_GET_INFOappears to have a similar bug, and needs updating fromhttps://uefi.org/specs/UEFI/2.11/37_Secure_Technologies.html#efi-rng-protocol-getinfo
. One bug at a time, though; this PR is for the bug I actually ran into.